On Wed, Jan 14, 2015 at 5:46 PM, Brad Smith <[email protected]> wrote:
> On 01/14/15 14:45, Chandler Carruth wrote: > >> Brad, I think it is completely unacceptable to change the default >> assembler behavior of every OS that delegates to Generic_GCC without any >> warning, heads up email, or discussion on the lists. >> > > It was on the list for everyone to see. It isn't as if its hiding. You submitted it without review, which means no one had a chance to see and comment. I specifically asked for a discussion on the mailing lists. If you want to change the behavior of all the OSes using this, then you at least need to *ask* whether the maintainers there want the change. > > It is especially unacceptable to do so when there are active problems on >> build bots and the tests aren't passing. This wasn't the first time this >> patch caused a problem either, and you are forcing several other >> developers to chase down build bot failures. >> > > What build bot failures? I haven't seen any and with the first patch I > did. Duncan cited bot failures when he reverted the patch the first time and Rafael pointed to an openbsd build bot failure. While I don't have the links handy, I don't think they were making them up.
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
