On Wed, Feb 4, 2015 at 8:19 PM, Ben Langmuir <[email protected]> wrote: > > On Feb 4, 2015, at 10:13 AM, İsmail Dönmez <[email protected]> wrote: > > On Wed, Feb 4, 2015 at 7:01 PM, Ben Langmuir <[email protected]> wrote: > > Index: llvm/tools/clang/test/Driver/mg.c > =================================================================== > --- llvm.orig/tools/clang/test/Driver/mg.c > +++ llvm/tools/clang/test/Driver/mg.c > @@ -1,5 +1,5 @@ > -// RUN: %clang -M -MG -include nonexistent-preinclude.h %s > %t > -// RUN: grep -F nonexistent-preinclude.h %t > -// RUN: grep -F nonexistent-ppinclude.h %t > +// RUN: %clang -M -MG -include nonexistent-preinclude.h %s 2>&1 | FileCheck > %s > +// CHECK: nonexistent-preinclude.h > +// CHECK: nonexistent-ppinclude.h > > #include "nonexistent-ppinclude.h” > > > > Is there a reason you’ve redirected stderr to stdout? The original test > only checked stdout and there shouldn’t be anything on stderr. > > > > Actually because thats what other FileCheck tests it in other files so > I just copied the idea. > > > Okay, I think we’re better without it because what we’re testing should all > be on stdout. LGTM with that change; do you need someone to commit this for > you?
Yes, please. Attached is without stderr redirection.
fgrep.patch
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
