> This patch merges the module map coverage check from the existing > module-map-checker tool into modularize.
Could you split this part out into a separate patch? Otherwise it is hard to review (i.e. delays review) since it's not clear what parts of the patch are what change. Moving module-map-checker into modularize should for the most part be a mechanical change where a reviewer can trivially see module-map-checker being deleted and moved into modularize. > It also allows a module map file to be used as the input to modularize, for > doing the usual checks modularize does, but extracting the file list from the > module map itself. This facilitates using modularize for regression testing > also. Please split this into a separate patch. > In the process of development, I also fixed a bug in the coverage check where > it wasn't recursively collecting files in umbrella directories. Please split this into a separate patch. http://reviews.llvm.org/D7475 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
