Nits: On Mon, Feb 9, 2015 at 11:23 AM, Ben Langmuir <[email protected]> wrote:
> + char hostname[256]; > + hostname[255] = 0; > + hostname[0] = 0; > + gethostname(hostname, 255); > It would be good to document that we want to actively ignore any error here. Also, pedantically you should set [255] to 0 here rather than above. POSIX doesn't require null termination in the event it is truncated. + code = hash_combine(code, StringRef(hostname)); > +#endif >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
