I agree with Richard here. As for the implementation, I think we need to delete the code in `Clang::ConstructJob` and decide whether we should enable/disable `-fsanitize=vptr` when we parse sanitizer arguments. This means we should factor out the function, that would tell us, if RTTI is (a) enabled, (b) disabled explicitly by certain argument (e.g. -fno-rtti, -mkernel, ...), (c) disabled implicitly (e.g. if we're targeting PS4). Then this function can be used both in `Clang::ConstructJob` and in `SanitizerArgs` constructor. Probably it can be a method of ToolChain, though I'm not sure here.
http://reviews.llvm.org/D7525 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
