================
Comment at: clang-tidy/readability/SimplifyBooleanExpr.cpp:16
@@ +15,3 @@
+
+using namespace clang;
+using namespace clang::ast_matchers;
----------------
alexfh wrote:
> I'd remove this and start namespace clang right after the next line.
Is it acceptable for me to add anonymous namespaces inside namespace clang?

================
Comment at: test/clang-tidy/readability-simplify-bool-expr.cpp:62
@@ +61,3 @@
+
+void if_with_bool_literal_condition()
+{
----------------
alexfh wrote:
> Please clang-format the test with LLVM style and infinite column limit (to 
> avoid breaking the CHECK lines).
Many of the tests are specifically designed to show that the user's whitespace 
is unmolested.

If I reformat the test file using clang-format, it will break all these tests.

A user can always run clang-format on the output of clang-tidy if they want 
LLVM formatting on the result.

http://reviews.llvm.org/D7648

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to