Nits are now addressed. Can someone please commit this for me? I lack commit
access.
Dean
On Tuesday, March 3, 2015 2:49 AM, Manuel Klimek <[email protected]> wrote:
Apart from the nits LG. Please fix those before submitting.
================
Comment at: include/clang/ASTMatchers/ASTMatchers.h:2035-2039
@@ +2034,7 @@
+/// matches the [webView ...] message invocation.
+/// \code
+/// NSString *webViewJavaScript = ...
+/// UIWebView *webView = ...
+/// [webView stringByEvaluatingJavaScriptFromString:webViewJavascript];
+/// \endcode
+AST_MATCHER_P(ObjCMessageExpr, hasReceiverType, internal::Matcher<QualType>,
----------------
Please indent the code sample by 2 (make it consistent).
================
Comment at: include/clang/ASTMatchers/ASTMatchers.h:2105
@@ +2104,3 @@
+/// webView.frame = bodyFrame;
+/// // ^---- matches here
+/// \endcode
----------------
Can you make the comment-in-the-comment align with the start of the statement
above?
http://reviews.llvm.org/D7710
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
