================
Comment at: lib/CodeGen/BackendUtil.cpp:256
@@ +255,3 @@
+ };
+ TLII->addVectorizableFunctions(VecFuncs);
+ break;
----------------
I think that I'd still rather add the functions to TLI inside of TLI. I like
the idea that the frontend can add others, and we should keep that capability.
However, there is no reason that other frontends should not be able to take
advantage of this knowledge. We should translate the Clang-level CodeGenOpt
into LLVM-level CodeGenOpts, and then add these there.
================
Comment at: lib/Driver/Tools.cpp:2854
@@ -2853,1 +2853,3 @@
+ if (Args.hasArg(options::OPT_fveclib)) {
+ if (Arg *A = Args.getLastArg(options::OPT_fveclib)) {
----------------
You don't need this if.
Furthermore, I think that this whole thing can be replaced by:
Args.AddLastArg(CmdArgs, options::OPT_fveclib);
http://reviews.llvm.org/D8097
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
