REPOSITORY
rL LLVM
================
Comment at: test/libcxx/test/executor.py:113
@@ -112,2 +112,3 @@
target_cwd = None
+ data_files = [f for f in os.listdir(work_dir) if f.endswith('.dat')]
try:
----------------
This feels like it's at the wrong level of abstraction. Shouldn't the "which
files do I copy in" part be determined by the caller?
================
Comment at: test/libcxx/test/executor.py:116
@@ -115,2 +115,3 @@
target_cwd = self.remote_temp_dir()
+ target_exe_path = os.path.join(target_cwd, 'libcxx_test')
if cmd:
----------------
EricWF wrote:
> Is is possible that two tests could be run in parallel and try and use the
> same path?
As long as the implementation of remote_temp_dir provides uniquing between the
processes, then this will be fine. For the SSHExecutor, that is implemented by
'mktemp -d', which DTRT. I don't remember off the top of my head what the
LocalExecutor does. It's definitely worth adding another "parallelism gotcha"
note to the Executor interface covering this situation.
http://reviews.llvm.org/D8118
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
