The changes LGTM with the Windows implementation fix.

Please update the commit message to indicate that this is an API break on 
Windows but it's probably inconsequential: any string used to be accepted, and 
now only the default string in the `random_device` ctor is accepted.


REPOSITORY
  rL LLVM

================
Comment at: src/random.cpp:122
@@ -83,4 +121,3 @@
 
-random_device::random_device(const string& __token)
-    : __f_(open(__token.c_str(), O_RDONLY))
+random_device::random_device(const string&)
 {
----------------
`__token`?

http://reviews.llvm.org/D8134

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to