Author: yrnkrn Date: Tue Mar 10 02:33:23 2015 New Revision: 231763 URL: http://llvm.org/viewvc/llvm-project?rev=231763&view=rev Log: Teach raw_ostream to accept SmallString.
Saves adding .str() call to any raw_ostream << SmallString usage and a small step towards making .str() consistent in the ADTs by removing one of the SmallString::str() use cases, discussion at http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20141013/240026.html I'll update the Phabricator patch http://reviews.llvm.org/D6372 for review of the Twine SmallString support, it's more complex than this one. Modified: cfe/trunk/lib/AST/ItaniumMangle.cpp cfe/trunk/lib/Lex/PPMacroExpansion.cpp cfe/trunk/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp cfe/trunk/tools/libclang/CIndex.cpp cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp Modified: cfe/trunk/lib/AST/ItaniumMangle.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ItaniumMangle.cpp?rev=231763&r1=231762&r2=231763&view=diff ============================================================================== --- cfe/trunk/lib/AST/ItaniumMangle.cpp (original) +++ cfe/trunk/lib/AST/ItaniumMangle.cpp Tue Mar 10 02:33:23 2015 @@ -1034,7 +1034,7 @@ void CXXNameMangler::mangleUnqualifiedNa Str += llvm::utostr(AnonStructId); Out << Str.size(); - Out << Str.str(); + Out << Str; break; } Modified: cfe/trunk/lib/Lex/PPMacroExpansion.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Lex/PPMacroExpansion.cpp?rev=231763&r1=231762&r2=231763&view=diff ============================================================================== --- cfe/trunk/lib/Lex/PPMacroExpansion.cpp (original) +++ cfe/trunk/lib/Lex/PPMacroExpansion.cpp Tue Mar 10 02:33:23 2015 @@ -1314,7 +1314,7 @@ void Preprocessor::ExpandBuiltinMacro(To if (PLoc.isValid()) { FN += PLoc.getFilename(); Lexer::Stringify(FN); - OS << '"' << FN.str() << '"'; + OS << '"' << FN << '"'; } Tok.setKind(tok::string_literal); } else if (II == Ident__DATE__) { Modified: cfe/trunk/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp?rev=231763&r1=231762&r2=231763&view=diff ============================================================================== --- cfe/trunk/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp (original) +++ cfe/trunk/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp Tue Mar 10 02:33:23 2015 @@ -735,7 +735,7 @@ static std::unique_ptr<ExplodedNode::Aud SmallString<128> P; int FD; llvm::sys::fs::createTemporaryFile("llvm_ubi", "", FD, P); - llvm::errs() << "Writing '" << P.str() << "'.\n"; + llvm::errs() << "Writing '" << P << "'.\n"; auto Stream = llvm::make_unique<llvm::raw_fd_ostream>(FD, true); Modified: cfe/trunk/tools/libclang/CIndex.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/libclang/CIndex.cpp?rev=231763&r1=231762&r2=231763&view=diff ============================================================================== --- cfe/trunk/tools/libclang/CIndex.cpp (original) +++ cfe/trunk/tools/libclang/CIndex.cpp Tue Mar 10 02:33:23 2015 @@ -7268,7 +7268,7 @@ cxindex::Logger::~Logger() { llvm::TimeRecord TR = llvm::TimeRecord::getCurrentTime(); OS << llvm::format("%7.4f] ", TR.getWallTime() - sBeginTR.getWallTime()); - OS << Msg.str() << '\n'; + OS << Msg << '\n'; if (Trace) { llvm::sys::PrintStackTrace(OS); Modified: cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp?rev=231763&r1=231762&r2=231763&view=diff ============================================================================== --- cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp (original) +++ cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp Tue Mar 10 02:33:23 2015 @@ -1162,7 +1162,7 @@ writePrettyPrintFunction(Record &R, OS << " case " << I << " : {\n" - " OS << \"" + Prefix.str() + Spelling.str(); + " OS << \"" << Prefix << Spelling; if (Variety == "Pragma") { OS << " \";\n"; @@ -1190,7 +1190,7 @@ writePrettyPrintFunction(Record &R, if (!Args.empty()) OS << ")"; - OS << Suffix.str() + "\";\n"; + OS << Suffix + "\";\n"; OS << " break;\n" _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
