Author: ed Date: Tue Mar 10 02:57:43 2015 New Revision: 231767 URL: http://llvm.org/viewvc/llvm-project?rev=231767&view=rev Log: Print log/error messages on stderr, not stdout
There are a couple of places where libc++ prints log/error messages to stdout on its own. This may of course interfere with the output generated with applications. Log/error messages should be directed to stderr instead. Differential Revision: http://reviews.llvm.org/D8135 Reviewed by: marshall Modified: libcxx/trunk/include/__debug libcxx/trunk/src/exception.cpp libcxx/trunk/src/string.cpp Modified: libcxx/trunk/include/__debug URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/__debug?rev=231767&r1=231766&r2=231767&view=diff ============================================================================== --- libcxx/trunk/include/__debug (original) +++ libcxx/trunk/include/__debug Tue Mar 10 02:57:43 2015 @@ -22,7 +22,7 @@ # include <cstdio> # include <cstddef> # ifndef _LIBCPP_ASSERT -# define _LIBCPP_ASSERT(x, m) ((x) ? (void)0 : (_VSTD::printf("%s\n", m), _VSTD::abort())) +# define _LIBCPP_ASSERT(x, m) ((x) ? (void)0 : (_VSTD::fprintf(stderr, "%s\n", m), _VSTD::abort())) # endif #endif Modified: libcxx/trunk/src/exception.cpp URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/src/exception.cpp?rev=231767&r1=231766&r2=231767&view=diff ============================================================================== --- libcxx/trunk/src/exception.cpp (original) +++ libcxx/trunk/src/exception.cpp Tue Mar 10 02:57:43 2015 @@ -90,14 +90,14 @@ terminate() _NOEXCEPT #endif // _LIBCPP_NO_EXCEPTIONS (*get_terminate())(); // handler should not return - printf("terminate_handler unexpectedly returned\n"); + fprintf(stderr, "terminate_handler unexpectedly returned\n"); ::abort(); #ifndef _LIBCPP_NO_EXCEPTIONS } catch (...) { // handler should not throw exception - printf("terminate_handler unexpectedly threw an exception\n"); + fprintf(stderr, "terminate_handler unexpectedly threw an exception\n"); ::abort(); } #endif // _LIBCPP_NO_EXCEPTIONS @@ -117,7 +117,7 @@ bool uncaught_exception() _NOEXCEPT # else # warning uncaught_exception not yet implemented # endif - printf("uncaught_exception not yet implemented\n"); + fprintf(stderr, "uncaught_exception not yet implemented\n"); ::abort(); #endif // __APPLE__ } @@ -190,7 +190,7 @@ exception_ptr::~exception_ptr() _NOEXCEP # else # warning exception_ptr not yet implemented # endif - printf("exception_ptr not yet implemented\n"); + fprintf(stderr, "exception_ptr not yet implemented\n"); ::abort(); #endif } @@ -209,7 +209,7 @@ exception_ptr::exception_ptr(const excep # else # warning exception_ptr not yet implemented # endif - printf("exception_ptr not yet implemented\n"); + fprintf(stderr, "exception_ptr not yet implemented\n"); ::abort(); #endif } @@ -234,7 +234,7 @@ exception_ptr& exception_ptr::operator=( # else # warning exception_ptr not yet implemented # endif - printf("exception_ptr not yet implemented\n"); + fprintf(stderr, "exception_ptr not yet implemented\n"); ::abort(); #endif } @@ -278,7 +278,7 @@ exception_ptr current_exception() _NOEXC # else # warning exception_ptr not yet implemented # endif - printf("exception_ptr not yet implemented\n"); + fprintf(stderr, "exception_ptr not yet implemented\n"); ::abort(); #endif } @@ -300,7 +300,7 @@ void rethrow_exception(exception_ptr p) # else # warning exception_ptr not yet implemented # endif - printf("exception_ptr not yet implemented\n"); + fprintf(stderr, "exception_ptr not yet implemented\n"); ::abort(); #endif } Modified: libcxx/trunk/src/string.cpp URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/src/string.cpp?rev=231767&r1=231766&r2=231767&view=diff ============================================================================== --- libcxx/trunk/src/string.cpp (original) +++ libcxx/trunk/src/string.cpp Tue Mar 10 02:57:43 2015 @@ -39,7 +39,7 @@ void throw_helper( const string& msg ) #ifndef _LIBCPP_NO_EXCEPTIONS throw T( msg ); #else - printf("%s\n", msg.c_str()); + fprintf(stderr, "%s\n", msg.c_str()); abort(); #endif } _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
