lgtm
================
Comment at: include/clang/Basic/ABI.h:28-29
@@ -29,1 +27,4 @@
+ Ctor_Comdat, ///< The COMDAT used for ctors
+ Ctor_CopyingClosure, ///< Copying closure variant of a ctor
+ Ctor_DefaultClosure, ///< Default closure variant of a ctor
};
----------------
rnk wrote:
> I'm not super psyched about adding to this enum. What do you think about
> adding custom entry points to the MS C++ ABI that just tweak internal bools?
Sure, if we think of this as just an enum of different constructor manglings,
then I guess this is OK.
================
Comment at: test/CodeGenCXX/microsoft-abi-throw.cpp:78
@@ +77,3 @@
+
+struct Bad {
+ template <typename T>
----------------
Maybe s/Bad/DoubleDefault/?
http://reviews.llvm.org/D8225
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
