Looks good! I'll address the two issues and commit the patch. Thank you for the fix!
================ Comment at: clang-tidy/misc/StaticAssertCheck.cpp:86 @@ +85,3 @@ + Lexer::getImmediateMacroName(FalseLiteralLoc, SM, Opts); + if (FalseMacroName == "false" || FalseMacroName == "False" || + FalseMacroName == "FALSE") ---------------- Use `StringRef::compare_lower` here. ================ Comment at: test/clang-tidy/misc-static-assert.cpp:16 @@ +15,3 @@ +#define False false +#define FALSE false + ---------------- Define one of these to 0 to test this option. http://reviews.llvm.org/D8328 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
