REPOSITORY
  rL LLVM

================
Comment at: src/Unwind/AddressSpace.hpp:60
@@ -59,3 +59,3 @@
 
-#if defined(__linux__)
+#if defined(__CloudABI__) || defined(__FreeBSD__) || defined(__linux__)
 #if _LIBUNWIND_SUPPORT_DWARF_UNWIND && _LIBUNWIND_SUPPORT_DWARF_INDEX
----------------
This part is safe.

================
Comment at: src/Unwind/AddressSpace.hpp:71
@@ -63,1 +70,3 @@
+#define ElfW3(width, type) Elf##width##_##type
+#endif
 #include "EHHeaderParser.hpp"
----------------
Hmm..Im not sure that this is the best way to approach this.  What if you want 
to do remote unwinding, where your host is 32-bit and your remote is 64-bit or 
vice-versa.  This breaks in that case, as you are using `__INTPTR_WIDTH__`.  Or 
am I overlooking something?

http://reviews.llvm.org/D8169

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to