REPOSITORY
  rL LLVM

================
Comment at: lib/Sema/SemaExpr.cpp:4611
@@ +4610,3 @@
+
+  if (!NeedsNewDecl)
+    return nullptr;
----------------
theraven wrote:
> This check looks expensive.  Have you profiled this on large codebases with a 
> lot of builtin calls?  I'd imagine that adding a DenseMap cache would be 
> faster.
I think the fast-path for builtins without pointers would help here.  What 
keys/data were you thinking would go in the DenseMap?

http://reviews.llvm.org/D8082

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to