On Fri, Mar 13, 2015 at 7:18 PM, David Blaikie <[email protected]> wrote: > > > On Fri, Mar 13, 2015 at 7:10 PM, Richard Smith <[email protected]> > wrote: >> >> On Fri, Mar 13, 2015 at 6:10 PM, Ahmed Bougacha <[email protected]> >> wrote: >>> >>> Author: ab >>> Date: Fri Mar 13 20:10:19 2015 >>> New Revision: 232237 >>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=232237&view=rev >>> Log: >>> Add a bunch of missing "CHECK" colons in tests. NFC. >> >> >> Yikes! Can we make FileCheck error on a check prefix followed by a space?
Yep, I got distracted halfway there; I'll give it another shot. > Just make the colon optional? (I wouldn't /actually/ like that, so I sort of > favor your suggestion, but in the name of usability I wonder if there's much > point to requiring the punctuation) There's not much point indeed, but I'd also prefer an error. > Though I seem to recall someone doing some test cleanup recently involving > misspellings of the CHECK prefix (either the literal CHECK, or misspelling > custom check prefixes, etc) Yeah, there's plenty more ways to fail, a missing colon is just the flavor of the day. It is among the easier ones to catch in FileCheck though. -Ahmed _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
