Other than the style comment I think this is fine.
We should probably grow more specialized object comparisons, but yes, that can
be done afterwards.
================
Comment at: utils/check_cfc/check_cfc.py:299
@@ +298,3 @@
+ # Sanity check
+ print("Check CFC, checking: {}".format(', '.join([check_name for
check_name in checks if config.getboolean('Checks', check_name)])))
+
----------------
80 columns ?
http://reviews.llvm.org/D8723
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
