================ Comment at: clang-tidy/misc/StaticAssertCheck.cpp:34 @@ -33,1 +33,3 @@ + auto IsAlwaysFalseWithCast = ignoringParenImpCasts(anyOf(IsAlwaysFalse, + cStyleCastExpr(hasDescendant(IsAlwaysFalse)))); auto AssertExprRoot = anyOf( ---------------- I'd say that the cast should be restricted to T*. Also, `hasDescendant` may be to loose. Isn't `has` (or `has(ignoringParenImpCasts(...))` if needed) enough here?
http://reviews.llvm.org/D8920 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
