On Thu, Apr 16, 2015 at 9:26 AM Richard <[email protected]> wrote:
> In http://reviews.llvm.org/D8149#157110, @klimek wrote: > > > Argh, sorry for missing it - please always feel free to ping earlier > (especially my reviews you can ping 2x per week). > > Can you please add a unit test? Apart from that it looks good. > > > I added a `FileCheck` test in the tools-extra repository (see > http://reviews.llvm.org/D8150). Is that sufficient, or would you also > like to see a unit test? > I'd like to see a unit test - we often make changes to the matcher infrastructure assuming all matchers are at least unit tested. > > > http://reviews.llvm.org/D8149 > > EMAIL PREFERENCES > http://reviews.llvm.org/settings/panel/emailpreferences/ > > >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
