Reid,

I'm forwarding this onto you since you are the original committer for r208733 which I wish to partially revert. The patch is attached and full(er) details
can be found at the bug report (link below).  Sorry for sending it to two
email addresses, but I don't know which is your active one.

I think you simply factored out code block too many, where (if I understand
your intentions correctly) you were factoring out the common code for
*ABI*::classifyReturnType but unintentionally included
DefaultABIInfo::classifyArgumentType, breaking ppc32 code generation.

Please can you review my patch to be sure I haven't done anything stupid
before I commit it.

Cheers
Andy


On Friday, May 15, 2015 11:46 AM, Andy Gibbs wrote:
Hi,

Please can someone have a look over the attached patch which fixes a
regression introduced in the refactoring of code in r208733 causing serious
invalid code generation on PPC32.

A full bug report is here: https://llvm.org/bugs/show_bug.cgi?id=23097

I'd quite like to get this committed before it is forgotten!

Cheers
Andy


Attachment: pr23097.diff
Description: Binary data

_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to