On Tue, May 26, 2015 at 7:54 PM David Majnemer <david.majne...@gmail.com> wrote:
> On Tue, May 26, 2015 at 7:22 PM, Chaoren Lin <chaor...@google.com> wrote: > >> Hi David, >> >> Thanks for your concern. >> >> The commit was intentional. I was hoping this small commit would fall >> under this part: >> >> smaller changes can be reviewed after commit >> >> >> of the LLVM Developer Policy >> <https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_docs_DeveloperPolicy.html-23code-2Dreviews&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=QuAaZphRKuyHP5n6oQVKXZjT9Q798WxBKrlU6YLePNI&s=ohuT68Er4qKRMq9onem2NyWK1BuTEIbtX1YABHqMsys&e=> >> > > I'm afraid it doesn't because of the following proviso: > > Code review can be an iterative process, which continues until the patch >> is ready to be committed. Specifically, once a patch is sent out for >> review, it needs an explicit “looks good” before it is submitted. Do not >> assume silent approval, or request active objections to the patch with a >> deadline. > > This section is just confusing. Slightly better wording is here: http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access This establishes the guideline of 'obvious'. I don't think any change I make (other than fixing the spelling of a comment) to a project I don't routinely contribute to would be "obvious" to me. The "small" and "obvious" wording aren't clear (I'll work to update the docs here) but I think they are supposed to cover the same set of changes, and I don't think they would cover any changes to a project you have little or no experience with previously. > > > >> We inlined a copy of this file in LLDB for Windows, and I ran into a >> problem where any mangled names with pointers or references in their >> argument list would cause a crash. Turns out that on Linux, String::front() >> consistently returns '\0' when empty, even though it should be undefined >> behavior. >> > >> It should be covered by existing tests if you enable asserts for libcxx >> and try to demangle "_Z1FPiRiOiMS0_FiiE". >> > > I don't see an existing test which tries to demangle > '_Z1FPiRiOiMS0_FiiE'. I think you should add it > to test/test_demangle.pass.cpp > > >> >> Thanks, >> Chaoren >> >> On Tue, May 26, 2015 at 4:43 PM, David Majnemer <david.majne...@gmail.com >> > wrote: >> >>> I didn't see anyone LGTM the phabricator review and no test has been >>> added for this change. Perhaps you accidentally committed this? >>> >>> On Tue, May 26, 2015 at 4:14 PM, Chaoren Lin <chaor...@google.com> >>> wrote: >>> >>>> Author: chaoren >>>> Date: Tue May 26 18:14:26 2015 >>>> New Revision: 238263 >>>> >>>> URL: http://llvm.org/viewvc/llvm-project?rev=238263&view=rev >>>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D238263-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=QuAaZphRKuyHP5n6oQVKXZjT9Q798WxBKrlU6YLePNI&s=dc2o1Gcmar0Ia3dwUAnef8_iONKHEibRLQHcMRxRVZU&e=> >>>> Log: >>>> Make sure !empty() before calling String::front(). >>>> >>>> Reviewers: howard.hinnant >>>> >>>> Subscribers: cfe-commits >>>> >>>> Differential Revision: http://reviews.llvm.org/D9954 >>>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D9954&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=QuAaZphRKuyHP5n6oQVKXZjT9Q798WxBKrlU6YLePNI&s=14VS6SUFIr2KjQuuTaWrupP-uks0B0Rrd9sohLh_25M&e=> >>>> >>>> Modified: >>>> libcxxabi/trunk/src/cxa_demangle.cpp >>>> >>>> Modified: libcxxabi/trunk/src/cxa_demangle.cpp >>>> URL: >>>> http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/src/cxa_demangle.cpp?rev=238263&r1=238262&r2=238263&view=diff >>>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_libcxxabi_trunk_src_cxa-5Fdemangle.cpp-3Frev-3D238263-26r1-3D238262-26r2-3D238263-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=QuAaZphRKuyHP5n6oQVKXZjT9Q798WxBKrlU6YLePNI&s=ygHBZOgwMcNkc7vMWXBjIett4-76FeOUf8fbbVzhxDk&e=> >>>> >>>> ============================================================================== >>>> --- libcxxabi/trunk/src/cxa_demangle.cpp (original) >>>> +++ libcxxabi/trunk/src/cxa_demangle.cpp Tue May 26 18:14:26 2015 >>>> @@ -1671,7 +1671,7 @@ parse_pointer_to_member_type(const char* >>>> auto func = std::move(db.names.back()); >>>> db.names.pop_back(); >>>> auto class_type = std::move(db.names.back()); >>>> - if (func.second.front() == '(') >>>> + if (!func.second.empty() && func.second.front() == '(') >>>> { >>>> db.names.back().first = std::move(func.first) + >>>> "(" + class_type.move_full() + "::*"; >>>> db.names.back().second = ")" + >>>> std::move(func.second); >>>> @@ -2018,7 +2018,8 @@ parse_type(const char* first, const char >>>> db.names[k].first += " ("; >>>> db.names[k].second.insert(0, ")"); >>>> } >>>> - else if (db.names[k].second.front() == >>>> '(') >>>> + else if (!db.names[k].second.empty() && >>>> + db.names[k].second.front() >>>> == '(') >>>> { >>>> db.names[k].first += "("; >>>> db.names[k].second.insert(0, ")"); >>>> @@ -2045,7 +2046,8 @@ parse_type(const char* first, const char >>>> db.names[k].first += " ("; >>>> db.names[k].second.insert(0, ")"); >>>> } >>>> - else if (db.names[k].second.front() == >>>> '(') >>>> + else if (!db.names[k].second.empty() && >>>> + db.names[k].second.front() >>>> == '(') >>>> { >>>> db.names[k].first += "("; >>>> db.names[k].second.insert(0, ")"); >>>> @@ -2079,7 +2081,8 @@ parse_type(const char* first, const char >>>> db.names[k].first += " ("; >>>> db.names[k].second.insert(0, ")"); >>>> } >>>> - else if (db.names[k].second.front() == >>>> '(') >>>> + else if (!db.names[k].second.empty() && >>>> + db.names[k].second.front() >>>> == '(') >>>> { >>>> db.names[k].first += "("; >>>> db.names[k].second.insert(0, ")"); >>>> >>>> >>>> _______________________________________________ >>>> cfe-commits mailing list >>>> cfe-commits@cs.uiuc.edu >>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >>>> >>> >>> >> _______________________________________________ > cfe-commits mailing list > cfe-commits@cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
