LGTM
================
Comment at: lib/AST/Expr.cpp:2899-2900
@@ +2898,4 @@
+ void VisitExpr(const Expr *E) {
+ if (E->HasSideEffects(Context, IncludePossibleEffects))
+ HasSideEffects = true;
+ }
----------------
Maybe only call `E->HasSideEffect(...)` if `HasSideEffect` is `false`. There's
no point doing more checking once we've already found a side-effect.
http://reviews.llvm.org/D10211
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
