================
Comment at: clang-tidy/misc/MacroRepeatedSideEffectsCheck.cpp:70
@@ +69,3 @@
+
+ if (!HasSideEffects(ResultArgToks))
+ continue;
----------------
alexfh wrote:
> nit: And now I'd revert the order of checks (HasSideEffects seems to be
> slightly cheaper?) and make this even simpler:
>
> if (HasSideEffects(ResultArgToks) && CountArgumentExpansions(MI, Arg) >= 2)
> {
> Check.diag(...) ...
> }
... reverse the order of checks ...
http://reviews.llvm.org/D9496
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
