> On Jun 25, 2015, at 12:26 PM, Chris Bieneman <[email protected]> wrote:
> 
> Hi bob.wilson, bogner,
> 
> For better or worse the OS X command line tools refer to the iOS simulator as 
> iphonesimucator. We should provide an alias flag 
> -miphonesimulator-version-min that matches a consistent pattern with the 
> other tools.
> 
> This is in the interest of making it easier for people to write 
> platform-agnostic darwin build scripts.
> 
> http://reviews.llvm.org/D10743
> 
> Files:
>  include/clang/Driver/Options.td
> 
> Index: include/clang/Driver/Options.td
> ===================================================================
> --- include/clang/Driver/Options.td
> +++ include/clang/Driver/Options.td
> @@ -1170,6 +1170,7 @@
> def mios_version_min_EQ : Joined<["-"], "mios-version-min=">,
>   Alias<miphoneos_version_min_EQ>, HelpText<"Set iOS deployment target">;
> def mios_simulator_version_min_EQ : Joined<["-"], 
> "mios-simulator-version-min=">, Alias<miphoneos_version_min_EQ>;
> +def miphonesimulator_version_min_EQ : Joined<["-"], 
> "miphonesimulator-version-min=">, Alias<mios_simulator_version_min_EQ>;
> def mkernel : Flag<["-"], "mkernel">, Group<m_Group>;
> def mlinker_version_EQ : Joined<["-"], "mlinker-version=">,
>   Flags<[DriverOption]>;
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> <D10743.28492.patch>

Please add a test, but otherwise, this is OK. Thanks for doing this.
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to