echristo accepted this revision. This revision is now accepted and ready to land.
Couple of inline comments, go ahead and commit when you've resolved them. Thanks! -eric ================ Comment at: lib/Driver/Tools.cpp:715-716 @@ +714,4 @@ + Features.push_back("+long-calls"); + } else if (KernelOrKext && (!Triple.isiOS() || Triple.isOSVersionLT(6))) { + Features.push_back("+long-calls"); + } ---------------- Can you add a plain english comment above this explaining what we're supposed to be checking here? :) ================ Comment at: test/CodeGen/arm-long-calls.c:3 @@ +2,3 @@ +// RUN: %clang_cc1 -triple thumbv7-apple-ios5 -emit-llvm -o - %s | FileCheck -check-prefix=NOLONGCALL %s + +// LONGCALL: attributes #0 = { {{.*}} "target-features"="+long-calls" ---------------- Test for -mno-long-calls? http://reviews.llvm.org/D9414 _______________________________________________ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits