wschmidt accepted this revision.
wschmidt added a comment.
This revision is now accepted and ready to land.

LGTM with additional commentary to explain what's going on. :)  Thanks.


================
Comment at: lib/Basic/Targets.cpp:1341
@@ +1340,3 @@
+  }
+  Features[Name] = Enabled;
+}
----------------
After chatting with you on IRC, the above logic is correct but it is still 
pretty hard to understand.  Please add a few more comments to explain the 
various scenarios.


Repository:
  rL LLVM

http://reviews.llvm.org/D10972




_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to