echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

This is a good start. We'll probably want to do some more refactoring, but this 
gets it in so we can look at it and make those decisions.

Make sure everything is formatted with clang-format, then LGTM.

-eric


================
Comment at: lib/Driver/Driver.cpp:822-823
@@ -820,3 +821,4 @@
 
 static unsigned PrintActions1(const Compilation &C, Action *A,
-                              std::map<Action*, unsigned> &Ids) {
+                              std::map<Action *, unsigned> &Ids);
+
----------------
tra wrote:
> echristo wrote:
> > Can you rearrange the code so that it doesn't need the forward declaration?
> Nope. PrintActions1 and PrintActionList call each other recursively. At least 
> one of them must have forward declaration.
Bleh. OK.

================
Comment at: lib/Driver/ToolChains.cpp:3668-3670
@@ +3667,5 @@
+
+llvm::opt::DerivedArgList *
+CudaToolChain::TranslateArgs(const llvm::opt::DerivedArgList &Args,
+                    const char *BoundArch) const {
+  DerivedArgList *DAL = new DerivedArgList(Args.getBaseArgs());
----------------
Formatting?


http://reviews.llvm.org/D9509




_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to