> > > Before my patch, code gen suppressed the emission of this function since > it was available externally, and as a result, EmitVisibility, and > thus MCSymbolELF::setVisibility, were simply never called. The undefined > symbol then ended up with the default visibility. It seems to me that this > essentially worked by luck. > > Yes, that is a bug in codegen. If the function should not be hidden clang should not be setting the visibility to hidden.
I will try to write a combined patch to change codegen and the new pass and see what is wrong in clang. Cheers, Rafael
_______________________________________________ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits