rnk added inline comments. ================ Comment at: tools/clang/lib/Driver/MinGWToolChain.cpp:206 @@ +205,3 @@ + +ToolChain::RuntimeLibType MinGW::GetRuntimeLibType(const ArgList &Args) const{ + if (Arg *A = Args.getLastArg(options::OPT_rtlib_EQ)) { ---------------- You don't need to override this, you can simply override GetDefaultRuntimeLibType() and leave the base class behavior for this.
================ Comment at: tools/clang/lib/Driver/ToolChains.h:546-552 @@ -545,2 +545,9 @@ llvm::opt::ArgStringList &CC1Args) const override; + void AddCXXStdlibLibArgs(const llvm::opt::ArgList &Args, + llvm::opt::ArgStringList &CmdArgs) const override; + + CXXStdlibType GetCXXStdlibType( + const llvm::opt::ArgList &Args) const override; + RuntimeLibType GetRuntimeLibType( + const llvm::opt::ArgList &Args) const override; ---------------- So far as I can tell, none of these overrides have any functionality change other than creating a place for TODOs. I'd rather just wait until we're ready to change the behavior, and then we can see how to do it with the least duplication. ================ Comment at: tools/clang/lib/Driver/Tools.cpp:9064 @@ -9053,3 +9063,3 @@ - AddLibGCC(Args, CmdArgs); + AddRuntime(TC, Args, CmdArgs); ---------------- Can't this just be AddRunTimeLibs() and then it won't require changing AddLibGCC? ================ Comment at: tools/clang/lib/Driver/Tools.cpp:9085 @@ -9074,3 +9084,3 @@ else if (!LinkerName.equals_lower("lld")) - AddLibGCC(Args, CmdArgs); + AddRuntime(TC, Args, CmdArgs); } ---------------- ditto http://reviews.llvm.org/D11237 _______________________________________________ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits