rsmith added inline comments.

================
Comment at: lib/CodeGen/TargetInfo.cpp:1653-1655
@@ +1652,5 @@
+  std::string ArgStr = Quote ? "\"" : "";
+  ArgStr += Lib;
+  ArgStr += Quote ? "\"" : "";
+  return ArgStr;
+}
----------------
ygao wrote:
> rsmith wrote:
> > What happens if the library name contains an embedded `\` character?
> Are you thinking of the evil case where the library name ends with a 
> backslash and then when we expand it, it might escape the separating 
> whitespace? When I test it, the embedded backslash character always gets 
> converted into an escape sequence "\5C" and hence looks harmless.
Curious. What is doing that escaping, and why is it not also escaping spaces?


http://reviews.llvm.org/D11275




_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to