kkwli0 marked 9 inline comments as done. ================ Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1099 @@ -1098,4 +1098,3 @@ /// } -static void emitOMPIfClause(CodeGenFunction &CGF, const Expr *Cond, - const RegionCodeGenTy &ThenGen, - const RegionCodeGenTy &ElseGen) { +void CodeGenFunction::EmitOMPIfClause(CodeGenFunction &CGF, const Expr *Cond, + const RegionCodeGenTy &ThenGen, ---------------- ABataev wrote: > 1. If EmitOMPIfClause is now a part of CodeGenFunction, it must be moved to > CGStmtOpenmp.cpp. > 2. The first argument CGF is not required, so remove it and use '*this' > instead. > 3. This changes must be committed in a separate patch (for codegen). Ok. I will leave the changes for the codegen patch.
http://reviews.llvm.org/D10765 _______________________________________________ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits