EricWF added a comment.
Respond to @mclow.lists inline comments. No change is needed to address the
concerns.
================
Comment at: include/__functional_03:207
@@ -206,3 +206,1 @@
-template<class _Fp> class _LIBCPP_TYPE_VIS_ONLY function; // undefined
-
namespace __function
----------------
mclow.lists wrote:
> It's not clear to me that removing this declaration is correct. There are
> specializations of `function` in this file.
It should be getting the declaration from `<functional>` before functional
includes `<__functional_03>` inline.
================
Comment at: include/__functional_03:761
@@ -771,3 +760,3 @@
{
- if (__not_null(__f))
+ if (__function::__not_null(__f))
{
----------------
mclow.lists wrote:
> Where is `__functional_03` getting the definition of `__not_null` from?
>
> It doesn't include any other headers.
`<__functional_03>` in included inline by `<functional>` *after* the definition
of `__not_null`.
================
Comment at: include/functional:1259
@@ -1238,2 +1258,2 @@
#include <__functional_03>
----------------
Here in the inline `<__functional_03>` include. You'll notice the foward
declaration of `function` and the definitions of `__not_null`.
http://reviews.llvm.org/D11111
_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
