> On Jul 21, 2015, at 12:39 PM, David Blaikie <dblai...@gmail.com> wrote: > > > > On Tue, Jul 21, 2015 at 12:31 PM, Pete Cooper <peter_coo...@apple.com > <mailto:peter_coo...@apple.com>> wrote: > Do you think this happens enough that it should be issued by clang with > -Wcompat? > > I haven't really looked at what else we put under that flag, if anything - so > I'm not sure if this would fit/meet the bar. I haven’t looked either. Just wanted to suggest it in case it did fit. > > I'm personally not too fussed by it. I just consider non-clang builds of > clang to be things we need to maintain, but not things we need to worry about > too much. So I'm usually OK with breaking GCC and MSVC buildbots and fixing > forwards for these little incompatibilities. Yeah, actually i’m fine with that too. Hopefully the bots don’t break so often that this is major blocker for people. If it is we can always revisit -Wcompat or other solutions later.
Cheers, Pete > > - Dave > > > Cheers, > Pete > > On Jul 21, 2015, at 11:59 AM, David Blaikie <dblai...@gmail.com > > <mailto:dblai...@gmail.com>> wrote: > > > > Author: dblaikie > > Date: Tue Jul 21 13:59:10 2015 > > New Revision: 242826 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=242826&view=rev > > <http://llvm.org/viewvc/llvm-project?rev=242826&view=rev> > > Log: > > Fix GCC build due to shadowing > > > > Modified: > > cfe/trunk/lib/CodeGen/CodeGenFunction.h > > > > Modified: cfe/trunk/lib/CodeGen/CodeGenFunction.h > > URL: > > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenFunction.h?rev=242826&r1=242825&r2=242826&view=diff > > > > <http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenFunction.h?rev=242826&r1=242825&r2=242826&view=diff> > > ============================================================================== > > --- cfe/trunk/lib/CodeGen/CodeGenFunction.h (original) > > +++ cfe/trunk/lib/CodeGen/CodeGenFunction.h Tue Jul 21 13:59:10 2015 > > @@ -3006,8 +3006,8 @@ public: > > "Extra arguments in non-variadic function!"); > > > > // If we still have any arguments, emit them using the type of the > > argument. > > - for (auto *Arg : llvm::make_range(Arg, ArgRange.end())) > > - ArgTypes.push_back(getVarArgType(Arg)); > > + for (auto *A : llvm::make_range(Arg, ArgRange.end())) > > + ArgTypes.push_back(getVarArgType(A)); > > > > EmitCallArgs(Args, ArgTypes, ArgRange, CalleeDecl, ParamsToSkip); > > } > > > > > > _______________________________________________ > > cfe-commits mailing list > > cfe-commits@cs.uiuc.edu <mailto:cfe-commits@cs.uiuc.edu> > > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > <http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits> > >
_______________________________________________ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
