kmensah added a comment. Responding to comments form djasper
================ Comment at: lib/Format/TokenAnnotator.cpp:1701 @@ -1700,2 +1700,3 @@ return Style.PenaltyReturnTypeOnItsOwnLine; - return 200; + unsigned penalty = 200; + if(Right.is(TT_StartOfName)) { ---------------- djasper wrote: > I don't understand this change. Could you elaborate? without this single Objective-C calls with no parameters ([self foo]) didn't have PenaltyBreakBeforeFirstCallParameter applied to stop a break before "foo". I wanted to return the max between the old default of 200 and PenaltyBreakBeforeFirstCallParameter but didn't want to have specify 200 multiple times. ================ Comment at: unittests/Format/FormatTest.cpp:7343-7344 @@ +7342,4 @@ + + // TODO: logic in ContinuationIndenter::moveStatePastFakeLParens adds more + // spaces than expected to second line. + verifyFormat("[[self foo] function:\n" ---------------- djasper wrote: > No, this is exactly as many spaces as intended. It is 4 spaces from > "function". Removed that statement. Repository: rL LLVM http://reviews.llvm.org/D11300 _______________________________________________ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits