RKSimon added a comment.

In http://reviews.llvm.org/D10838#212425, @mpflanzer wrote:

> Hi Simon, is this test case enough? Clang will fail with an exit code other 
> than 0 if wrong code is generated. The test passes with my changes. Or should 
> I add a check to the test that something like `<2 x i64> <i64 0, i64 undef>` 
> is not generated?


Yes please add a FileCheck stage to the test to give some insight as to what 
you expect the result to be.

A comment would be useful as well (reference the PR# and a brief explanation of 
the bug).


http://reviews.llvm.org/D10838




_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to