chandlerc added a subscriber: chandlerc.
chandlerc added a comment.
Comments from the peanut gallery...
================
Comment at: lib/Driver/Tools.cpp:9482-9488
@@ -9481,13 +9481,9 @@
- // Any -O option passes through without translation. What about -Ofast ?
- if (Arg *A = Args.getLastArg(options::OPT_O_Group))
- A->render(Args, CmdArgs);
-
- if (Args.hasFlag(options::OPT_ffunction_sections,
- options::OPT_fno_function_sections)) {
- CmdArgs.push_back("-ffunction-sections");
- }
- if (Args.hasArg(options::OPT_fno_inline_functions))
- CmdArgs.push_back("-fno-inline-functions");
-
+ Args.AddAllArgs(CmdArgs,
+ options::OPT_f_Group,
+ options::OPT_f_clang_Group,
+ options::OPT_g_Group);
+ Args.AddAllArgs(CmdArgs,
+ options::OPT_O_Group,
+ options::OPT_W_Group);
CmdArgs.push_back("-fno-exceptions"); // Always do this even if unspecified.
----------------
How worried are you about eventual incompatibilities between the flags in these
groups for the driver and for the underlying SHAVE compiler? I'm moderately
worried...
How many flags are we talking about here? Also, the -W flags worry me less than
the rest.
Finally, why two AddAllArgs?
http://reviews.llvm.org/D11581
_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
