rnk accepted this revision. rnk added a reviewer: rnk. rnk added a comment. This revision is now accepted and ready to land.
lgtm with slightly tighter test case. ================ Comment at: tools/clang/test/CodeGenCXX/vtable-key-function-win-comdat.cpp:18 @@ +17,2 @@ +// CHECK: $_ZTS6Test1a = comdat any +// CHECK-NOT: $_ZTI6Test1a.1 = comdat any ---------------- Can you also CHECK that the vtable definition has the right name, linkage, and uses this comdat? Repository: rL LLVM http://reviews.llvm.org/D11594 _______________________________________________ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
