EricWF added inline comments. ================ Comment at: include/ios:373 @@ -371,2 +372,3 @@ +#if defined(_LIBCPP_HAS_C_ATOMIC_IMP) && !defined(_LIBCPP_HAS_NO_THREADS) static atomic<int> __xindex_; #else ---------------- mclow.lists wrote: > Do you need to address this TODO before committing? (and the one in <memory> > ?) > Do you need to address this TODO before committing?
I would rather make the change in the TODO separately. I want to be sure that enabling this for both the Clang and GCC implementations of atomic will not cause ODR or ABI problems. I think these concerns should be addressed in a different patch. http://reviews.llvm.org/D11555 _______________________________________________ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits