beanz added a comment.

In general I'd like a more generic solution, but I don't think we have the 
infrastructure for that yet, so I have no objection to the patches being done 
like this.

See my comment inline below for the one thing that needs to change.

Thanks,
-Chris


================
Comment at: src/CMakeLists.txt:123
@@ -124,1 +122,3 @@
+  LIBRARY DESTINATION lib${LIBCXXABI_LIBDIR_SUFFIX} COMPONENT libcxxabi
+  ARCHIVE DESTINATION lib${LIBCXXABI_LIBDIR_SUFFIX} COMPONENT libcxxabi
   )
----------------
You should not specify both ARCHIVE and LIBRARY in the same install command. 
One of the two will be ignored. As per the documentation 
(http://www.cmake.org/cmake/help/v3.0/command/install.html).

You will need to do something similar to what is done in AddLLVM.cmake:507-520.


http://reviews.llvm.org/D11682




_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to