beanz added a comment. Chandler,
I would eventually like to make install be bootstrap-install in cases where CLANG_ENABLE_BOOTSTRAP=On. Doing that will require a larger reworking of how clang's install targets are structured. It is on my todo list, but in the interest of sending out smaller patches I wanted to send this out early and expand it in the public tree. We can document the existing behavior in the Building LLVM With CMake documentation under frequently used variables (http://llvm.org/docs/CMake.html#frequently-used-cmake-variables). I'm not super familiar with the ExternalProject support, but since you can't import targets from the external project I don't think we'll want to do a bootstrap-check-foo for all foo. Unless someone from the CMake community has some better ideas how to do that. Part of my motivation for prototyping this up was to start getting to know ExternalProject so that I can take advantage of it for compiler-rt. I don't want bootstrap to do bootstrap-install either, but I can't find a way to make bootstrap-install work without it being part of the bootstrap target. If it is alright with you, I'd really like to land this mostly as is, and iterate on it in-tree. There should be no real risk to this because it is fully gated by an option that defaults off. Thanks, -Chris ================ Comment at: CMakeLists.txt:565 @@ +564,3 @@ + USES_TERMINAL_BUILD 1 + USES_TERMINAL_INSTALL 1) + endif() ---------------- filcab wrote: > Nit: not consistent with the other parens closing multi-line > macros/directives. I will fix this and update the patches. http://reviews.llvm.org/D11743 _______________________________________________ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
