Resending to cfe-commits. You can tell I'm doing this for the first time. :-)
---------- Forwarded message ---------- From: Zhanyong Wan (λx.x x) <[email protected]> Date: 2009/10/14 Subject: Re: please review: fix for http://llvm.org/PR4407 To: [email protected] 2009/10/14 Zhanyong Wan (λx.x x) <[email protected]>: > Hi, > > I have a patch that fixes the first issue in http://llvm.org/PR4407 : > > Clang should warn on a case value that exceeds the range of the type in > switch. > const char ch = 'a'; > switch(ch) { > case 1234: // expected-warning {{overflow converting case value}} > break; > } > > I uploaded the patch to http://codereview.appspot.com/130078/show. The URL doesn't include the period in the end: http://codereview.appspot.com/130078/show Thanks, > Could someone review it? > > This is the first time I work on clang, so please let me know if I'm > following the coding convention correctly. Thanks, > > -- > Zhanyong > -- Zhanyong _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
