On Jan 14, 2010, at 9:47 AM, Chris Lattner wrote: > > On Jan 13, 2010, at 4:48 PM, Devang Patel wrote: > >> Author: dpatel >> Date: Wed Jan 13 18:48:09 2010 >> New Revision: 93389 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=93389&view=rev >> Log: >> Because CurLoc is the current source location as far as CGDebugInfo is >> concerned. It is expected that this is set (usually left bracket location of >> function body compound statement) before EmitfunctionStart() is used. > > Please add a comment to the code.
Done. > > -Chris > >> >> Modified: >> cfe/trunk/lib/CodeGen/CGDebugInfo.cpp >> >> Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDebugInfo.cpp?rev=93389&r1=93388&r2=93389&view=diff >> >> ============================================================================== >> --- cfe/trunk/lib/CodeGen/CGDebugInfo.cpp (original) >> +++ cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Wed Jan 13 18:48:09 2010 >> @@ -1014,7 +1014,6 @@ >> LinkageName = Name; >> } >> >> - // FIXME: Why is this using CurLoc??? >> llvm::DICompileUnit Unit = getOrCreateCompileUnit(CurLoc); >> SourceManager &SM = CGM.getContext().getSourceManager(); >> unsigned LineNo = SM.getPresumedLoc(CurLoc).getLine(); >> >> >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
