On May 24, 2010, at 5:33 PM, Daniel Dunbar wrote:

> Author: ddunbar
> Date: Mon May 24 19:33:13 2010
> New Revision: 104577
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=104577&view=rev
> Log:
> IRgen/C++: When mark vtables used, make sure to still append to the VTableUse 
> array if we promote a vtable from being just used to having its definition 
> required. This ensures that we properly inform the consumer about whether the 
> vtable is required or not, previously we could fail to do so when the vtable 
> was in the VTableUses array before the decl which marked it as required.
> - I think this can be cleaned up, since this means we may notify the consumer 
> about the vtable twice, but I didn't see an easy fix for this without more 
> substantial refactoring.
> - Doug, please review!

Looks fine to me, thanks!

        - Doug
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to