On Mon, Sep 27, 2010 at 5:20 AM, Zoxc <[email protected]> wrote: > This patch adds a 'naked' attribute for functions which simply maps to > LLVM's 'naked' function attribute. It should be equivalent to GCC's > naked attribute. > > Added a review request since I've never touched the codebase before.
Patch looked great, applied in r115056. I made two minor tweaks to capitalize a sentence and indent slightly differently, but I see you followed the style of the surrounding code so no complaints there. I fixed the surrounding code too. :) We've moved to prefer using FileCheck in tests instead of grep, so if you feel like updating the tests to use FileCheck that has become more standard, but it isn't a big deal in a test this small. - Daniel > - Zoxc > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
