Hi Marcin,
Overall the patch looks good. But one problem:
@@ -126,7 +130,8 @@
idx::TranslationUnit
*TU) {
AnalysisContext *&AC = Contexts[D];
if (!AC)
- AC = new AnalysisContext(D, TU, UseUnoptimizedCFG);
+ AC = new AnalysisContext(D, TU, UseUnoptimizedCFG, AddImplicitDtors,
+ AddInitializers);
Notice that the fourth parameter is bool addehedges = false. We could set it
to false for now. In the future we would add an option for it, too.
You could spot this bug by actually running clang with the patch on a test
case:
$ clang -cc1 -analyze -cfg-view -cfg-add-implicit-dtors scope.cpp
And see no effect with the new option.
And for each patch, you can run 'make test' to ensure it does not break
regression tests.
2010/9/30 Marcin Świderski <[email protected]>
> Patch adds two new command line arguments:
> -cfg-add-implicit-dtors - sets CFG::BuildOptions::AddImplicitDtors for
> AnalysisCosumer to true
> -cfg-add-initializers - sets CFG::BuildOptions::AddInitializers for
> AnalysisCosumer to true
>
> Please approve for commit.
>
> Marcin
>
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
