On Mon, Apr 4, 2011 at 4:58 PM, Bob Wilson <bob.wil...@apple.com> wrote:
>
> On Mar 31, 2011, at 2:06 PM, Sandeep Patel wrote:
>
>> Clang aligns NEON vectors differently than llvm-gcc does.
>>
>> llvm-gcc actually calls into ARMTargetMachine to get the layout, but
>> Clang provides it's own definitions.
>>
>> llvm-gcc's definition appears to be correct, so this changes Clang to that.
>
> Thanks, Sandeep.  While reviewing your patch, I noticed that further changes 
> were needed for the APCS ABI, so I went ahead and made those changes as well. 
>  Committed as svn r128825.
>

Now that you made me look at the parts beyond v128 :-), I'm doubting
the AACPS values for i1,i8, and i16.

The layouts in ARMTargetMachine.cpp for ARM don't have these smaller
integer types listed at all. Should they be explicit?

deep

_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to