On Tue, Sep 6, 2011 at 6:53 PM, Jakob Stoklund Olesen <stokl...@2pi.dk>wrote:
> On Sep 6, 2011, at 6:47 PM, Chandler Carruth wrote: > > > Author: chandlerc > > Date: Tue Sep 6 20:47:09 2011 > > New Revision: 139217 > > > > - void EmitCaretDiagnostic(SourceLocation Loc, CharSourceRange *Ranges, > > - unsigned NumRanges, const SourceManager &SM, > > + void EmitCaretDiagnostic(SourceLocation Loc, > > + SmallVectorImpl<CharSourceRange> &Ranges, > > Should this be an ArrayRef too? > I *really* wanted it to be one. Sadly, we mutate the source ranges as part of the recursive walk through the macro expansions. =[ I'll look into whether we can do that on the stack as copies eventually; I'm hoping to isolate that recursive walk more before I start messing with it
_______________________________________________ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
