Hi, > On Mon, Nov 28, 2011 at 10:07 PM, Chandler Carruth <[email protected]> > wrote: >> Your commit message doesn't mention this other recovery change:
Sorry about that! This other change was making the error-recovery for templated function definitions with the 'typedef' specifier match the error-recovery for the non-templated case. On Tue, November 29, 2011 06:23, David Blaikie wrote: > It'd also be rather easy to implement a fixit for this recovery too, > just on the diagnostic a few lines above: > > Diag(Tok, diag::err_function_declared_typedef) << > FixItHint::CreateRemoval(DS.getStorageClassSpecLoc()); Yes, if we are suitably confident that removing the 'typedef' keyword is the right fix. I think that is probably fine -- I've personally only ever seen this happen once, and there the 'typedef' keyword was supposed to be 'typename' (which we will have already provided a separate fixit to add). Richard _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
