On Wed, Feb 15, 2012 at 12:09 PM, Delesley Hutchins <[email protected]>wrote:
> This is a simple fix that allows mutex expressions to refer to types > that are forward-declared, and thus not lockable. > > http://codereview.appspot.com/5672057/ > Hi Delesley, I've made a couple of minor comments on the codereview tool. Regarding the new diagnostic, how about something like: "GCC requires function attribute '%0' to be written at the start of the function definition"? Also, I'd prefer for this warning to live under a switch like -Wgcc-compat rather than -Wattributes. Thanks, Richard
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
